Fix incorrect port mapping of 2368 and update to latest docker image version#1713
Closed
hong823 wants to merge 2 commits intodocker-library:masterfrom
Closed
Fix incorrect port mapping of 2368 and update to latest docker image version#1713hong823 wants to merge 2 commits intodocker-library:masterfrom
hong823 wants to merge 2 commits intodocker-library:masterfrom
Conversation
hong823
changed the title
Member
|
It's not "incorrect" so much as "intentionally using a different host port than the port inside the container" which is why the line in the YAML has two values (the first being the "outside port" and the second being the "inside port" which is the port Ghost/Node is listening on). What we should probably do instead is add an example |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ghost's port is displayed as
8080which is incorrect, port2368should be the correct port as there are URLs on the page that is redirecting to port2368.Example: